Просмотр исходного кода

cnic: Fix an error handling path in 'cnic_alloc_bnx2x_resc()'

All the error handling paths 'goto error', except this one.
We should also go to error in this case, or some resources will be
leaking.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Christophe JAILLET 8 лет назад
Родитель
Сommit
05cf97e7a6
1 измененных файлов с 1 добавлено и 1 удалено
  1. 1 1
      drivers/net/ethernet/broadcom/cnic.c

+ 1 - 1
drivers/net/ethernet/broadcom/cnic.c

@@ -1278,7 +1278,7 @@ static int cnic_alloc_bnx2x_resc(struct cnic_dev *dev)
 
 
 	ret = cnic_alloc_dma(dev, kwq_16_dma, pages, 0);
 	ret = cnic_alloc_dma(dev, kwq_16_dma, pages, 0);
 	if (ret)
 	if (ret)
-		return -ENOMEM;
+		goto error;
 
 
 	n = CNIC_PAGE_SIZE / CNIC_KWQ16_DATA_SIZE;
 	n = CNIC_PAGE_SIZE / CNIC_KWQ16_DATA_SIZE;
 	for (i = 0, j = 0; i < cp->max_cid_space; i++) {
 	for (i = 0, j = 0; i < cp->max_cid_space; i++) {