Эх сурвалжийг харах

net: core: rtnetlink: use BUG_ON instead of if condition followed by BUG

Use BUG_ON instead of if condition followed by BUG in do_setlink.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Gustavo A. R. Silva 7 жил өмнө
parent
commit
058c8d5912

+ 1 - 2
net/core/rtnetlink.c

@@ -2274,8 +2274,7 @@ static int do_setlink(const struct sk_buff *skb,
 
 
 			rcu_read_lock();
 			rcu_read_lock();
 
 
-			if (!(af_ops = rtnl_af_lookup(nla_type(af))))
-				BUG();
+			BUG_ON(!(af_ops = rtnl_af_lookup(nla_type(af))));
 
 
 			err = af_ops->set_link_af(dev, af);
 			err = af_ops->set_link_af(dev, af);
 			if (err < 0) {
 			if (err < 0) {