Bläddra i källkod

net: hns: bug fix for return values

The return values in the first two functions mdiobus_write()
are ignored. The patch will fix it.

Signed-off-by: Qianqian Xie <xieqianqian@huawei.com>
Signed-off-by: Yisen Zhuang <Yisen.Zhuang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Qianqian Xie 9 år sedan
förälder
incheckning
055a94177d
1 ändrade filer med 2 tillägg och 2 borttagningar
  1. 2 2
      drivers/net/ethernet/hisilicon/hns/hns_ethtool.c

+ 2 - 2
drivers/net/ethernet/hisilicon/hns/hns_ethtool.c

@@ -1013,8 +1013,8 @@ int hns_phy_led_set(struct net_device *netdev, int value)
 	struct phy_device *phy_dev = priv->phy;
 	struct phy_device *phy_dev = priv->phy;
 
 
 	retval = phy_write(phy_dev, HNS_PHY_PAGE_REG, HNS_PHY_PAGE_LED);
 	retval = phy_write(phy_dev, HNS_PHY_PAGE_REG, HNS_PHY_PAGE_LED);
-	retval = phy_write(phy_dev, HNS_LED_FC_REG, value);
-	retval = phy_write(phy_dev, HNS_PHY_PAGE_REG, HNS_PHY_PAGE_COPPER);
+	retval |= phy_write(phy_dev, HNS_LED_FC_REG, value);
+	retval |= phy_write(phy_dev, HNS_PHY_PAGE_REG, HNS_PHY_PAGE_COPPER);
 	if (retval) {
 	if (retval) {
 		netdev_err(netdev, "mdiobus_write fail !\n");
 		netdev_err(netdev, "mdiobus_write fail !\n");
 		return retval;
 		return retval;