瀏覽代碼

Utilities: Fix missing parentheses in ACPI_GET_BITS()/ACPI_SET_BITS()

Some compilers require parentheses to be enforced in the macro definition,
so that the macro caller side can be simpler.

This patch fixes this kind of macro issue in
ACPI_SET_BITS()/ACPI_GET_BITS(). Lv Zheng.

Link: https://bugs.acpica.org/show_bug.cgi?id=1268
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Lv Zheng 9 年之前
父節點
當前提交
0461f34e16
共有 1 個文件被更改,包括 2 次插入2 次删除
  1. 2 2
      drivers/acpi/acpica/acmacros.h

+ 2 - 2
drivers/acpi/acpica/acmacros.h

@@ -287,10 +287,10 @@
 /* Generic bitfield macros and masks */
 /* Generic bitfield macros and masks */
 
 
 #define ACPI_GET_BITS(source_ptr, position, mask) \
 #define ACPI_GET_BITS(source_ptr, position, mask) \
-	((*source_ptr >> position) & mask)
+	((*(source_ptr) >> (position)) & (mask))
 
 
 #define ACPI_SET_BITS(target_ptr, position, mask, value) \
 #define ACPI_SET_BITS(target_ptr, position, mask, value) \
-	(*target_ptr |= ((value & mask) << position))
+	(*(target_ptr) |= (((value) & (mask)) << (position)))
 
 
 #define ACPI_1BIT_MASK      0x00000001
 #define ACPI_1BIT_MASK      0x00000001
 #define ACPI_2BIT_MASK      0x00000003
 #define ACPI_2BIT_MASK      0x00000003