Преглед изворни кода

memcg: remove unnecessary !mm check from try_get_mem_cgroup_from_mm()

Users pass either a mm that has been established under task lock, or use
a verified current->mm, which means the task can't be exiting.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Michal Hocko <mhocko@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Johannes Weiner пре 11 година
родитељ
комит
03583f1a63
1 измењених фајлова са 0 додато и 7 уклоњено
  1. 0 7
      mm/memcontrol.c

+ 0 - 7
mm/memcontrol.c

@@ -1075,13 +1075,6 @@ struct mem_cgroup *try_get_mem_cgroup_from_mm(struct mm_struct *mm)
 {
 {
 	struct mem_cgroup *memcg = NULL;
 	struct mem_cgroup *memcg = NULL;
 
 
-	if (!mm)
-		return NULL;
-	/*
-	 * Because we have no locks, mm->owner's may be being moved to other
-	 * cgroup. We use css_tryget() here even if this looks
-	 * pessimistic (rather than adding locks here).
-	 */
 	rcu_read_lock();
 	rcu_read_lock();
 	do {
 	do {
 		memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
 		memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));