Эх сурвалжийг харах

arm64/crypto: remove redundant update of data

Originally found by cppcheck:

[arch/arm64/crypto/sha2-ce-glue.c:153]: (warning) Assignment of
  function parameter has no effect outside the function. Did you
  forget dereferencing it?

Updating data by blocks * SHA256_BLOCK_SIZE at the end of
sha2_finup is redundant code and can be removed.

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Colin Ian King 11 жил өмнө
parent
commit
031cb42838

+ 0 - 1
arch/arm64/crypto/sha2-ce-glue.c

@@ -150,7 +150,6 @@ static void sha2_finup(struct shash_desc *desc, const u8 *data,
 	kernel_neon_begin_partial(28);
 	kernel_neon_begin_partial(28);
 	sha2_ce_transform(blocks, data, sctx->state, NULL, len);
 	sha2_ce_transform(blocks, data, sctx->state, NULL, len);
 	kernel_neon_end();
 	kernel_neon_end();
-	data += blocks * SHA256_BLOCK_SIZE;
 }
 }
 
 
 static int sha224_finup(struct shash_desc *desc, const u8 *data,
 static int sha224_finup(struct shash_desc *desc, const u8 *data,