소스 검색

Input: evdev - fix variable initialisation

Commit 509f87c5f564 (evdev - do not block waiting for an event if fd
is nonblock) created a code path were it was possible to use retval
uninitialized.

This could lead to the xorg evdev input driver getting corrupt data
and refusing to work with log messages like
	AUO-Pixcir touchscreen: Read error: Success
	sg060_keys: Read error: Success
	AUO-Pixcir touchscreen: Read error: Success
	sg060_keys: Read error: Success
(for drivers auo-pixcir-ts and gpio-keys).

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Dima Zavin <dima@android.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Heiko Stübner 14 년 전
부모
커밋
02dfc49680
1개의 변경된 파일1개의 추가작업 그리고 1개의 파일을 삭제
  1. 1 1
      drivers/input/evdev.c

+ 1 - 1
drivers/input/evdev.c

@@ -332,7 +332,7 @@ static ssize_t evdev_write(struct file *file, const char __user *buffer,
 	struct evdev_client *client = file->private_data;
 	struct evdev_client *client = file->private_data;
 	struct evdev *evdev = client->evdev;
 	struct evdev *evdev = client->evdev;
 	struct input_event event;
 	struct input_event event;
-	int retval;
+	int retval = 0;
 
 
 	if (count < input_event_size())
 	if (count < input_event_size())
 		return -EINVAL;
 		return -EINVAL;