Browse Source

x86/microcode/intel: Fix memleak in save_microcode_patch()

Free useless ucode_patch entry when it's replaced.

[ bp: Drop the memfree_patch() two-liner. ]

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Srinivas REDDY Eeda <srinivas.eeda@oracle.com>
Link: http://lkml.kernel.org/r/888102f0-fd22-459d-b090-a1bd8a00cb2b@default
Zhenzhong Duan 7 years ago
parent
commit
0218c76626
1 changed files with 4 additions and 1 deletions
  1. 4 1
      arch/x86/kernel/cpu/microcode/intel.c

+ 4 - 1
arch/x86/kernel/cpu/microcode/intel.c

@@ -190,8 +190,11 @@ static void save_microcode_patch(void *data, unsigned int size)
 			p = memdup_patch(data, size);
 			p = memdup_patch(data, size);
 			if (!p)
 			if (!p)
 				pr_err("Error allocating buffer %p\n", data);
 				pr_err("Error allocating buffer %p\n", data);
-			else
+			else {
 				list_replace(&iter->plist, &p->plist);
 				list_replace(&iter->plist, &p->plist);
+				kfree(iter->data);
+				kfree(iter);
+			}
 		}
 		}
 	}
 	}