Browse Source

ASoC: Intel: fix broadwell module removing failed issue

In haswell-pcm module unloading, we can't free runtime modules
directly, for they may be already freed in runtime suspend.

Here add executing suspend call to unload runtime modules, only
for status not equal to RPM_SUSPEND, to fix broadwell module
removing failed issue.

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Signed-off-by: Jie Yang <yang.jie@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Liam Girdwood 10 years ago
parent
commit
01f202c7b4
1 changed files with 3 additions and 1 deletions
  1. 3 1
      sound/soc/intel/haswell/sst-haswell-pcm.c

+ 3 - 1
sound/soc/intel/haswell/sst-haswell-pcm.c

@@ -1103,8 +1103,10 @@ static int hsw_pcm_remove(struct snd_soc_platform *platform)
 		snd_soc_platform_get_drvdata(platform);
 		snd_soc_platform_get_drvdata(platform);
 	int i;
 	int i;
 
 
+	/* execute a suspend call to unload all FW resources */
+	if (!pm_runtime_status_suspended(platform->dev))
+		pm_runtime_put_sync_suspend(platform->dev);
 	pm_runtime_disable(platform->dev);
 	pm_runtime_disable(platform->dev);
-	hsw_pcm_free_modules(priv_data);
 
 
 	for (i = 0; i < ARRAY_SIZE(hsw_dais); i++) {
 	for (i = 0; i < ARRAY_SIZE(hsw_dais); i++) {
 		if (hsw_dais[i].playback.channels_min)
 		if (hsw_dais[i].playback.channels_min)