Browse Source

ata: sata_dwc_460ex: remove redundant dev_err call

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Tejun Heo <tj@kernel.org>
Wei Yongjun 9 years ago
parent
commit
01c292068e
1 changed files with 2 additions and 8 deletions
  1. 2 8
      drivers/ata/sata_dwc_460ex.c

+ 2 - 8
drivers/ata/sata_dwc_460ex.c

@@ -259,11 +259,8 @@ static int sata_dwc_dma_init_old(struct platform_device *pdev,
 	/* Get physical SATA DMA register base address */
 	/* Get physical SATA DMA register base address */
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
 	hsdev->dma->regs = devm_ioremap_resource(&pdev->dev, res);
 	hsdev->dma->regs = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(hsdev->dma->regs)) {
-		dev_err(&pdev->dev,
-			"ioremap failed for AHBDMA register address\n");
+	if (IS_ERR(hsdev->dma->regs))
 		return PTR_ERR(hsdev->dma->regs);
 		return PTR_ERR(hsdev->dma->regs);
-	}
 
 
 	/* Initialize AHB DMAC */
 	/* Initialize AHB DMAC */
 	return dw_dma_probe(hsdev->dma);
 	return dw_dma_probe(hsdev->dma);
@@ -1227,11 +1224,8 @@ static int sata_dwc_probe(struct platform_device *ofdev)
 	/* Ioremap SATA registers */
 	/* Ioremap SATA registers */
 	res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
 	res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
 	base = devm_ioremap_resource(&ofdev->dev, res);
 	base = devm_ioremap_resource(&ofdev->dev, res);
-	if (IS_ERR(base)) {
-		dev_err(&ofdev->dev,
-			"ioremap failed for SATA register address\n");
+	if (IS_ERR(base))
 		return PTR_ERR(base);
 		return PTR_ERR(base);
-	}
 	dev_dbg(&ofdev->dev, "ioremap done for SATA register address\n");
 	dev_dbg(&ofdev->dev, "ioremap done for SATA register address\n");
 
 
 	/* Synopsys DWC SATA specific Registers */
 	/* Synopsys DWC SATA specific Registers */