Переглянути джерело

pinctrl: coh901: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Linus Walleij 9 роки тому
батько
коміт
01a62834f9
1 змінених файлів з 1 додано та 1 видалено
  1. 1 1
      drivers/pinctrl/pinctrl-coh901.c

+ 1 - 1
drivers/pinctrl/pinctrl-coh901.c

@@ -221,7 +221,7 @@ static int u300_gpio_get(struct gpio_chip *chip, unsigned offset)
 {
 {
 	struct u300_gpio *gpio = to_u300_gpio(chip);
 	struct u300_gpio *gpio = to_u300_gpio(chip);
 
 
-	return readl(U300_PIN_REG(offset, dir)) & U300_PIN_BIT(offset);
+	return !!(readl(U300_PIN_REG(offset, dir)) & U300_PIN_BIT(offset));
 }
 }
 
 
 static void u300_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
 static void u300_gpio_set(struct gpio_chip *chip, unsigned offset, int value)