0001-utils-rename-base64_-encode-decode.patch 5.1 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134
  1. From 9e68787576fec304da23af26dca963a4cdea7765 Mon Sep 17 00:00:00 2001
  2. From: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
  3. Date: Tue, 8 Nov 2016 23:42:53 +0530
  4. Subject: [PATCH] utils: rename base64_{encode,decode}
  5. When statically linking with gnutls, we get definition clash error for
  6. base64_encode which is also defined by gnutls.
  7. /home/rahul.bedarkar/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libgnutls.a(base64.o): In function `base64_encode':
  8. base64.c:(.text+0x148): multiple definition of `base64_encode'
  9. utils.o:utils.c:(.text+0x4378): first defined here
  10. collect2: error: ld returned 1 exit status
  11. To prevent definition clash, rename base64_{encode,decode}
  12. Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
  13. ---
  14. src/http-ntlm.c | 6 +++---
  15. src/http.c | 4 ++--
  16. src/utils.c | 8 ++++----
  17. src/utils.h | 4 ++--
  18. 4 files changed, 11 insertions(+), 11 deletions(-)
  19. diff --git a/src/http-ntlm.c b/src/http-ntlm.c
  20. index 56c40ae..87f5a37 100644
  21. --- a/src/http-ntlm.c
  22. +++ b/src/http-ntlm.c
  23. @@ -122,7 +122,7 @@ ntlm_input (struct ntlmdata *ntlm, const char *header)
  24. DEBUGP (("Received a type-2 NTLM message.\n"));
  25. - size = base64_decode (header, buffer);
  26. + size = wget_base64_decode (header, buffer);
  27. if (size < 0)
  28. return false; /* malformed base64 from server */
  29. @@ -411,7 +411,7 @@ ntlm_output (struct ntlmdata *ntlm, const char *user, const char *passwd,
  30. size = 32 + hostlen + domlen;
  31. base64 = (char *) alloca (BASE64_LENGTH (size) + 1);
  32. - base64_encode (ntlmbuf, size, base64);
  33. + wget_base64_encode (ntlmbuf, size, base64);
  34. output = concat_strings ("NTLM ", base64, (char *) 0);
  35. break;
  36. @@ -584,7 +584,7 @@ ntlm_output (struct ntlmdata *ntlm, const char *user, const char *passwd,
  37. /* convert the binary blob into base64 */
  38. base64 = (char *) alloca (BASE64_LENGTH (size) + 1);
  39. - base64_encode (ntlmbuf, size, base64);
  40. + wget_base64_encode (ntlmbuf, size, base64);
  41. output = concat_strings ("NTLM ", base64, (char *) 0);
  42. diff --git a/src/http.c b/src/http.c
  43. index 7e60a07..368d30d 100644
  44. --- a/src/http.c
  45. +++ b/src/http.c
  46. @@ -2818,7 +2818,7 @@ metalink_from_http (const struct response *resp, const struct http_stat *hs,
  47. char *bin_hash = alloca (dig_hash_str_len * 3 / 4 + 1);
  48. size_t hash_bin_len;
  49. - hash_bin_len = base64_decode (dig_hash, bin_hash);
  50. + hash_bin_len = wget_base64_decode (dig_hash, bin_hash);
  51. /* One slot for me, one for zero-termination. */
  52. mfile->checksums =
  53. @@ -4546,7 +4546,7 @@ basic_authentication_encode (const char *user, const char *passwd)
  54. sprintf (t1, "%s:%s", user, passwd);
  55. t2 = (char *)alloca (BASE64_LENGTH (len1) + 1);
  56. - base64_encode (t1, len1, t2);
  57. + wget_base64_encode (t1, len1, t2);
  58. return concat_strings ("Basic ", t2, (char *) 0);
  59. }
  60. diff --git a/src/utils.c b/src/utils.c
  61. index b07da9f..355f0ce 100644
  62. --- a/src/utils.c
  63. +++ b/src/utils.c
  64. @@ -2140,7 +2140,7 @@ xsleep (double seconds)
  65. base64 data. */
  66. size_t
  67. -base64_encode (const void *data, size_t length, char *dest)
  68. +wget_base64_encode (const void *data, size_t length, char *dest)
  69. {
  70. /* Conversion table. */
  71. static const char tbl[64] = {
  72. @@ -2208,7 +2208,7 @@ base64_encode (const void *data, size_t length, char *dest)
  73. This function originates from Free Recode. */
  74. ssize_t
  75. -base64_decode (const char *base64, void *dest)
  76. +wget_base64_decode (const char *base64, void *dest)
  77. {
  78. /* Table of base64 values for first 128 characters. Note that this
  79. assumes ASCII (but so does Wget in other places). */
  80. @@ -2588,7 +2588,7 @@ wg_pubkey_pem_to_der (const char *pem, unsigned char **der, size_t *der_len)
  81. base64data = xmalloc (BASE64_LENGTH(stripped_pem_count));
  82. - size = base64_decode (stripped_pem, base64data);
  83. + size = wget_base64_decode (stripped_pem, base64data);
  84. if (size < 0) {
  85. xfree (base64data); /* malformed base64 from server */
  86. @@ -2651,7 +2651,7 @@ wg_pin_peer_pubkey (const char *pinnedpubkey, const char *pubkey, size_t pubkeyl
  87. end_pos[0] = '\0';
  88. /* decode base64 pinnedpubkey, 8 is length of "sha256//" */
  89. - decoded_hash_length = base64_decode (begin_pos + 8, expectedsha256sumdigest);
  90. + decoded_hash_length = wget_base64_decode (begin_pos + 8, expectedsha256sumdigest);
  91. /* if valid base64, compare sha256 digests directly */
  92. if (SHA256_DIGEST_SIZE == decoded_hash_length &&
  93. !memcmp (sha256sumdigest, expectedsha256sumdigest, SHA256_DIGEST_SIZE)) {
  94. diff --git a/src/utils.h b/src/utils.h
  95. index f224b73..aaac730 100644
  96. --- a/src/utils.h
  97. +++ b/src/utils.h
  98. @@ -140,8 +140,8 @@ void xsleep (double);
  99. /* How many bytes it will take to store LEN bytes in base64. */
  100. #define BASE64_LENGTH(len) (4 * (((len) + 2) / 3))
  101. -size_t base64_encode (const void *, size_t, char *);
  102. -ssize_t base64_decode (const char *, void *);
  103. +size_t wget_base64_encode (const void *, size_t, char *);
  104. +ssize_t wget_base64_decode (const char *, void *);
  105. #ifdef HAVE_LIBPCRE
  106. void *compile_pcre_regex (const char *);
  107. --
  108. 2.6.2